Skip to content

feat(vortex-geo): add area scalar function - #9203

Open
HarukiMoriarty wants to merge 3 commits into
nemo/geo-native-bbox-precheckfrom
nemo/geo-area
Open

feat(vortex-geo): add area scalar function#9203
HarukiMoriarty wants to merge 3 commits into
nemo/geo-native-bbox-precheckfrom
nemo/geo-area

Conversation

@HarukiMoriarty

@HarukiMoriarty HarukiMoriarty commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a native GeoArea scalar function backed by geo::Area::unsigned_area
  • support every native geometry dtype, including zero-area point and line families and rectangular boxes
  • preserve input nullability and propagate null rows through unary columnar execution
  • give every geo scalar function a local operand validator that checks exact arity before dtype validation
  • parameterize repeated Area, Envelope, and MakeLine cases with rstest for clearer per-dtype failures and broader operand-order coverage

Semantics

This follows DuckDB ST_Area semantics over the native Vortex geometry types: point and line families return zero, polygon holes are subtracted, multipolygon component areas are summed, rectangles use width times height, and higher coordinate dimensions are ignored. WKB remains excluded because it is a storage representation rather than a native decoded geometry.

@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 10.62%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 1900 untouched benchmarks
🆕 4 new benchmarks
⏩ 43 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation compress_fsst[(1000, 64, 8)] 1 ms 1.2 ms -10.62%
🆕 Simulation multipolygon N/A 2.7 ms N/A
🆕 Simulation nullable_polygon N/A 1.4 ms N/A
🆕 Simulation polygon_with_holes N/A 2.3 ms N/A
🆕 Simulation simple_polygon N/A 1 ms N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing nemo/geo-area (7040417) with nemo/geo-native-bbox-precheck (72a4ae1)

Open in CodSpeed

Footnotes

  1. 43 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant